If your junk hangs out, they're too short.

Seriously though, as long as they have a long slit up the side, they can be fairly long without restricting your range of motion. My MMA shorts come down atleast halfway to my knees but the cut up the side of the shorts keep them from binding when I throw kicks.